OHRI-2263 Refactor tab and use the reusable tabs component (PMTCT) #1900
Conversation
| launchOptions={tab.launchOptions} | ||
| /> | ||
| ))} | ||
| <EncounterListTabsComponent patientUuid={patientUuid} configSchema={motherPreviousVisitConfigSchema} config={config} /> |
There was a problem hiding this comment.
@CynthiaKamau this might not work because this wasn't a tab, we had such cases in the covid app and for now I would say we just leave it as it is unless we decide to render everything as a tab. if you see this has no tabs or tabPanels but if we treat it like this, it will have that blue tab design, we need to make a decision about this, personally I would say we make every menu that renders the encounter list table a tab. I don't know what you think. cc @lucyjemutai
There was a problem hiding this comment.
I also realised you didn't do the same for hivExposedInfant, so let's have a sync about this and see how we wanna handle that
There was a problem hiding this comment.
@CynthiaKamau this might not work because this wasn't a tab, we had such cases in the covid app and for now I would say we just leave it as it is unless we decide to render everything as a tab. if you see this has no tabs or tabPanels but if we treat it like this, it will have that blue tab design, we need to make a decision about this, personally I would say we make every menu that renders the encounter list table a tab. I don't know what you think. cc @lucyjemutai
It is a list of tabs
There was a problem hiding this comment.
How is it working because in the code it doesn't look like that, we were just rendering the Encounter list
Requirements
OHRI-123 My PR title.Summary
Refactor tab and use the reusable tabs component (PMTCT)
Screenshots
Related Issue
Other